Skip to content

fix: pass through touches in KeyboardToolbar#1440

Merged
kirillzyusko merged 2 commits intomainfrom
fix/keyboard-toolbar-touches-pass-through
Apr 17, 2026
Merged

fix: pass through touches in KeyboardToolbar#1440
kirillzyusko merged 2 commits intomainfrom
fix/keyboard-toolbar-touches-pass-through

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Apr 17, 2026

📜 Description

Fixed an issue when touches pas through KeyboardToolbar.

💡 Motivation and Context

The issue was because KeyboardStickyView had 0x0 dimensions. As a result that View wasn't visible for touch system in react-native and focus was forwarded further (to input or other elements that can handle a touch).

The fix is quite trivial - we simply adding missing style (fixed height, 100% width).

I also hope it can fix the issue on Android 31 e2e tests and make KeyboardToolbar tests stable again 🤞

Closes #1021

📢 Changelog

JS

  • added styles.toolbar to KeyboardStickyView style;

🤔 How Has This Been Tested?

Tested on Pixel 7 Pro (API 36).

📸 Screenshots (if appropriate):

Android

Paper Fabric
telegram-cloud-document-2-5409326574178702586.mp4
telegram-cloud-document-2-5409326574178702578.mp4

iOS (verical)

iOS 18.5 iOS 26.2
image image

iOS (horizontal)

iOS 18.5 iOS 26.2
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Apr 17, 2026
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working KeyboardToolbar Anything related to KeyboardToolbar component labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

📊 Package size report

Current size Target Size Difference
313105 bytes 312781 bytes 324 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review April 17, 2026 13:09
@github-actions
Copy link
Copy Markdown
Contributor

LGTM

@kirillzyusko kirillzyusko merged commit 15111a4 into main Apr 17, 2026
17 checks passed
@kirillzyusko kirillzyusko deleted the fix/keyboard-toolbar-touches-pass-through branch April 17, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working KeyboardToolbar Anything related to KeyboardToolbar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch events pass through KeyboardToolbar on RN 0.79+

1 participant