fix: pass through touches in KeyboardToolbar#1440
Merged
kirillzyusko merged 2 commits intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
📊 Package size report
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed an issue when touches pas through
KeyboardToolbar.💡 Motivation and Context
The issue was because
KeyboardStickyViewhad0x0dimensions. As a result thatViewwasn't visible for touch system inreact-nativeand focus was forwarded further (to input or other elements that can handle a touch).The fix is quite trivial - we simply adding missing
style(fixedheight,100%width).I also hope it can fix the issue on Android 31 e2e tests and make
KeyboardToolbartests stable again 🤞Closes #1021
📢 Changelog
JS
styles.toolbartoKeyboardStickyViewstyle;🤔 How Has This Been Tested?
Tested on Pixel 7 Pro (API 36).
📸 Screenshots (if appropriate):
Android
telegram-cloud-document-2-5409326574178702586.mp4
telegram-cloud-document-2-5409326574178702578.mp4
iOS (verical)
iOS (horizontal)
📝 Checklist